Fix the ClusterListener, ServerListener, ServerMonitorListener API docs relevant to thread-safety
#1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…API docs relevant to thread-safety JAVA-5185
JAVA-5185
JAVA-5185
jyemin
approved these changes
Sep 29, 2023
…mory synchronization is needed JAVA-5185
rozza
reviewed
Oct 4, 2023
There was a problem hiding this comment.
I'm not sure the average Java developer will know what "writes to shared memory" means in relation to their Java app.
How about something like:
However, this guarantee does not mean that implementations automatically do not need to synchronize memory accesses to prevent data races. For example, if any data that the listener collects is accessed oustide of the normal execution of the listener by the {@code MongoClient}, then any reading and writing actions must be synchronized.
rozza
approved these changes
Oct 4, 2023
JAVA-5185
|
@rozza, I implemented you suggestion, thank you! Merging, because the static checks have passed, and everything else is irrelevant for the changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5185